Skip to content
This repository has been archived by the owner. It is now read-only.

Fixing telemetry + cocoapods setup #265

Merged
merged 9 commits into from Mar 20, 2019
Next

force the exact version of cocoapods

  • Loading branch information
chrmod committed Mar 18, 2019
commit 30b2f7d948eb52e373a664503bcfb8d230218987
@@ -2,7 +2,8 @@ source 'https://rubygems.org'

gem 'danger', :git => 'git@github.com:danger/danger.git', :branch => 'master'
gem 'danger-swiftlint'
gem 'cocoapods', '1.5.3'
gem 'fastlane'

gem "fastlane"
plugins_path = File.join(File.dirname(__FILE__), 'fastlane', 'Pluginfile')
eval_gemfile(plugins_path) if File.exist?(plugins_path)
@@ -33,7 +33,7 @@ Building the code
```
1. Install [cocoadpods](https://cocoapods.org/)
```shell
sudo gem install cocoapods
bundle install
```
1. Fork the repository https://github.com/ghostery/browser-ios
1. Clone the forked repository:
@@ -46,7 +46,7 @@ Building the code
sh ./bootstrap.sh
npm install
npm run bundle
pod install
bundle exec pod install
```
1. Open `Client.xcworkspace` in Xcode.
1. Build the `Fennec` scheme in Xcode.
@@ -96,4 +96,4 @@ npm run build
### Commits
* Each commit should have a single clear purpose. If a commit contains multiple unrelated changes, those changes should be split into separate commits.
* If a commit requires another commit to build properly, those commits should be squashed.
* Follow-up commits for any review comments should be squashed. Do not include "Fixed PR comments", merge commits, or other "temporary" commits in pull requests.
* Follow-up commits for any review comments should be squashed. Do not include "Fixed PR comments", merge commits, or other "temporary" commits in pull requests.
ProTip! Use n and p to navigate between commits in a pull request.