This repository has been archived by the owner. It is now read-only.
Adblocker + Control Center API #27
Closed
Conversation
| let key = key(elem) | ||
| if var dict_array = dict[key] { | ||
| dict_array.append(elem) | ||
| dict[key] = dict_array |
mahmoud-adam85
May 7, 2018
Contributor
I think this line is redundant
I think this line is redundant
|
|
||
| public func groupAndReduce<B:Hashable, C>(byKey: (Element) -> B, reduce: ([Element]) -> C) -> Dictionary<B, C> { | ||
| let dict = self.groupBy(key: byKey) | ||
| var reduceDict: Dictionary<B,C> = [:] |
mahmoud-adam85
May 7, 2018
Contributor
return dict.reduceValues instead of duplicating the code
return dict.reduceValues instead of duplicating the code
timoteipalade
May 8, 2018
Author
Contributor
Yap. Thank you!
Yap. Thank you!
|
the commits here are part of the Control Center branch. They will be merged from there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.