Skip to content
This repository has been archived by the owner. It is now read-only.

Cliqz Search #3

Merged
merged 2 commits into from Mar 2, 2018
Merged

Cliqz Search #3

merged 2 commits into from Mar 2, 2018

Conversation

@timoteipalade
Copy link
Contributor

@timoteipalade timoteipalade commented Mar 2, 2018

No description provided.

@timoteipalade timoteipalade force-pushed the timoteipalade:master branch from 8a3b8fc to 3a5b79f Mar 2, 2018
searchController!.profile = self.profile

//Cliqz: Replace Search Controller
// let isPrivate = tabManager.selectedTab?.isPrivate ?? false

This comment has been minimized.

@mahmoud-adam85

mahmoud-adam85 Mar 2, 2018
Contributor

could you please use /* */ for commenting Firefox code

@@ -1763,6 +1773,21 @@ extension BrowserViewController: SearchViewControllerDelegate {
}
}

//Cliqz: Replace Search Controller

This comment has been minimized.

@naira-cliqz

naira-cliqz Mar 2, 2018
Contributor

It would be better to add the extension in separate file under the Cliqz

@timoteipalade timoteipalade force-pushed the timoteipalade:master branch 2 times, most recently from 70df83d to 9c3d9f4 Mar 2, 2018
@timoteipalade timoteipalade force-pushed the timoteipalade:master branch from 9c3d9f4 to d97ce52 Mar 2, 2018
@naira-cliqz naira-cliqz merged commit deb8c6a into ghostery:master Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants