This repository has been archived by the owner. It is now read-only.
[IP-558] Fixes Sentry bugs related to LogoLoader #340
Merged
Conversation
This prevents various race conditions when initializing, where the JSON logo database was parsed multiple times. We’re hoping this will eliminate some crash sources surrounding logo loading.
ghost
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Update LogoLoader to make it a Singleton. This prevents various race conditions when initializing, where the JSON logo database was parsed multiple times. We’re hoping this will eliminate various crash sources surrounding logo loading.
Pull Request Checklist
Bug 12345678 - This fixes something something[needsuplift]NSLocalizableString()Screenshots
n/a
Notes for testing this patch
I could not reproduce the crash in sentry, so this is hard to test. What I found out is that the JSON parsing method, which was supposed to be called only once, was called multiple times. Refactoring LogoLoader into a singleton pattern fixes that. I have high hopes that this will at least greatly reduce the number of crashes relating to LogoLoader.