This repository has been archived by the owner. It is now read-only.
[IP-550] [Telemetry] Allow testers to set developer flag #346
Conversation
…nt signal Add isDeveloperModeOn property to UserPreferences and if on, send that as a preference to Engine. Update AboutSettingsTableViewController.swift to load the current status of UserPreferences.instance.isDeveloperModeOn if the hidden “More Info” mode is accessed via a two finger long press gesture.
This is to prevent the Ghostery and Cliqz builds from failing, but adding the feature there as well doesn’t hurt.
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add
isDeveloperModeOnproperty toUserPreferencesand iftruesend that as a preference to Engine. (The flag is calleddeveloperin the Engine for historical reasons.)Update
AboutSettingsTableViewController.swiftto load the current status ofUserPreferences.instance.isDeveloperModeOnif the hidden “More Info” mode is accessed via a two finger long press gesture.Pull Request Checklist
Bug 12345678 - This fixes something something[needsuplift]NSLocalizableString()Screenshots
Notes for testing this patch
developersignal is sent