This repository has been archived by the owner. It is now read-only.
[IB-1926] [Bug] Updated MappaMundi breaks build #380
Merged
Conversation
The Cartfile we inherited from Firefox contains this line: `github "mozilla-mobile/MappaMundi" "master"` recently, MappaMundi was [updated to use the A-Star project](mozilla-mobile/MappaMundi#17) for pathfinding. This project, however, needs Swift 5. Hence, the build is broken. To fix, pin the MappaMundi version to a commit before they introduce the A-Star algorithm.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The Cartfile we inherited from Firefox contains this line:
recently, MappaMundi was updated to use the A-Star project for pathfinding. This project, however, needs Swift 5. Hence, the build is broken.
To fix, pin the MappaMundi version to a commit before they introduce the A-Star algorithm.
Pull Request Checklist
[IP-123] This fixes something somethingNSLocalizableString()Screenshots
Notes for testing this patch