Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation issue #121

Closed
FrankOnGit opened this issue Jul 5, 2018 · 2 comments
Closed

German translation issue #121

FrankOnGit opened this issue Jul 5, 2018 · 2 comments
Assignees

Comments

@FrankOnGit
Copy link

@FrankOnGit FrankOnGit commented Jul 5, 2018

Please read the CONTRIBUTING guide before submitting an issue.

Description

German translation issue:
The phrase "Navigate to another page and I promise I'll deliver the goods." cannot be directly translated to "Navigieren Sie zu einer anderen Seite und ich verspreche, dass ich liefern werde."

Expected Behavior

I don't speak English good enough to understand the meaning of "deliver the goods", so please ask somebody else for the correct translation.

Actual Behavior

[What actually happened]

Steps to Reproduce

  1. [First Step]
    open source code github.com/ghostery/ghostery-extension/blob/master/_locales/de/messages.json on line 456
  2. [Second Step]
    replace "dass ich liefern werde" using something ordinary
@Aziz-Ghostery
Copy link

@Aziz-Ghostery Aziz-Ghostery commented Jul 6, 2018

We have looked into this issue and found that the correct translation is:
"Navigieren Sie zu einer anderen Seite und ich verspreche, dass ich meine Arbeit erledigen werde."
A ticket has been added GH-1257 - we'll tag you when its fixed.

@christophertino christophertino self-assigned this Jul 6, 2018
@christophertino
Copy link
Member

@christophertino christophertino commented Jul 6, 2018

This will be in the 8.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants