Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Uncaught TypeError: Cannot read property 'href' of null at u (content_script_bundle.js:1) #214

Closed
vHeemstra opened this issue Oct 17, 2018 · 5 comments

Comments

@vHeemstra
Copy link

@vHeemstra vHeemstra commented Oct 17, 2018

Description of bug

When using JSFiddle, my browser's console shows uncaught TypeErrors from the Ghostery extension script whenever I click after one of these characters (,),[,],},} (when it's the last character on the line) in the editor field.

NB: I've seen it in other situations/on other websites happening as well, but this is just an example.

Expected Behavior

Nothing / No errors in the console

Actual Behavior

The console shows this error: Uncaught TypeError: Cannot read property 'href' of null at u (content_script_bundle.js:1). It occurs at line 1, character 26556 (e.target.parentNode.href).

Steps to Reproduce

  1. Go to this small JSFiddle example
  2. Open your browser's console
  3. Click at the line endings after the characters

Versions

  • Browser: Chrome version 69.0.3497.100 (64bits)
  • OS: Windows 10 Pro
  • Node: version 6.9.1
  • NPM: version 3.10.9
@philipp-classen
Copy link
Contributor

@philipp-classen philipp-classen commented Oct 18, 2018

Thank you for the bug report, I get the same error.

This is the code that throws:
https://github.com/cliqz-oss/browser-core/blob/master/modules/core/sources/content.es#L224

@philipp-classen
Copy link
Contributor

@philipp-classen philipp-classen commented Oct 25, 2018

Should be fixed in the next release.

@jordanranson
Copy link

@jordanranson jordanranson commented Nov 20, 2018

When will that be? This is still an issue.

@christophertino
Copy link
Member

@christophertino christophertino commented Nov 27, 2018

@jordanranson We released v8.2.5 today which should fix the issue. Please update and let us know.

@jordanranson
Copy link

@jordanranson jordanranson commented Nov 27, 2018

@christophertino Seems to be good now! Thanks for the hard work guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants