Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery v8.2.5 for Firefox prompts users to re-acknowledge permissions #253

Open
christophertino opened this issue Nov 27, 2018 · 2 comments
Open

Comments

@christophertino
Copy link
Member

@christophertino christophertino commented Nov 27, 2018

The v8.2.5 release on Firefox is prompting users to re-accept Ghostery's permissions via an upgrade dialog. This is triggered by #234, which allows Ghostery to catch trackers and ads served over WebSockets ("ws://*/*", "wss://*/*"). This is the only permission that was changed and it has not triggered a similar permission dialog in Chrome or Opera.

There's an open Bugzilla bug to address why Firefox is forcing users to acknowledge permissions again:
"Adding ftp/ws/wss permissions should not trigger extension permission warnings on extension upgrade"

@dwaal
Copy link

@dwaal dwaal commented Nov 29, 2018

This also struck me as odd. Especially since there is no mention in the 8.2.5 changelog talking about requiring new permissions.

@christophertino
Copy link
Member Author

@christophertino christophertino commented Nov 29, 2018

Yes, it's pretty disappointing. The changelog mentions adding WebSocket support but not the new permissions because the permission dialog was not triggered in our normal regression testing. Apparently to test these warnings you need to self-sign and host your test builds on an HTTPS server and then jump through some other hoops as outlined here.

It's also concerning that some of our users aren't receiving the permission dialog in the url bar. Instead, it's buried in the FF hamburger menu and if you don't see it, the permission request just goes away when you close Firefox.
ff_menu

Since most of our users are now stuck on 8.2.4 and we're taking a bath on our review board, we're going to release an 8.2.6 build with WebSocket support removed on Firefox. Hopefully we can work with Firefox to acknowledge that this is a redundant permission prompt. Users have already agreed to the "allow access to data on all websites" permission on installation (via "http://*/*", "https://*/*" permissions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants