Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery breaks direct Amazon S3 uploads that use pre-signed URLs #263

Closed
rbjarnason opened this issue Dec 6, 2018 · 3 comments
Closed

Ghostery breaks direct Amazon S3 uploads that use pre-signed URLs #263

rbjarnason opened this issue Dec 6, 2018 · 3 comments
Assignees

Comments

@rbjarnason
Copy link

@rbjarnason rbjarnason commented Dec 6, 2018

Description

We've been adding video upload features to our open source citizens participation application. After quite a bit of debugging we've found that Ghostery blocks our direct uploads to Amazon S3 using pre signed URLs. The reason is that Ghostery rewrites the outgoing PUT query string parameter from "x-amz-acl: bucket-owner-full-control" to "x-amz-acl: ghostery" invalidating the signature on that URL.

Here is the relevant code from our side: https://github.com/CitizensFoundation/your-priorities-app/blob/master/client_app/src/yp-file-upload/yp-file-upload.html#L759

Expected Behavior

We expect Ghostery not to rewrite our x-amz-acl query parameter to ghostery and to be able to upload files directly to S3 without 403 errors.

Actual Behavior

Ghosty rewrites the query string parameter from "x-amz-acl: bucket-owner-full-control" to "x-amz-acl: ghostery" invalidating the signature on that URL.

Steps to Reproduce

  1. Get a signed PUT URL from Amazon
  2. Upload a file from the browser using Javascript using that signed URL
  3. It will fail

Versions

  • Browser: All
  • OS: All
  • Node:
  • NPM:
@rbjarnason rbjarnason changed the title Ghostery breaks direct Amazon S3 uploads that use signed URLs Ghostery breaks direct Amazon S3 uploads that use pre-signed URLs Dec 6, 2018
@christophertino
Copy link
Member

@christophertino christophertino commented Dec 6, 2018

@rbjarnason Thanks for the heads up. This looks like a false-positive in our anti-tracking system. We're currently working on a fix.

@christophertino
Copy link
Member

@christophertino christophertino commented Dec 10, 2018

We've updated our whitelist implementation on the anti-tracking back-end to fix this issue. @rbjarnason Could you please test and let us know if the problem is resolved?

@rbjarnason
Copy link
Author

@rbjarnason rbjarnason commented Dec 10, 2018

@christophertino This works now, thanks for a quick response, I'm closing the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants