Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Screen on Youtube and many other sites is not working #310

Closed
jupiter14 opened this issue Jan 10, 2019 · 5 comments
Closed

Full Screen on Youtube and many other sites is not working #310

jupiter14 opened this issue Jan 10, 2019 · 5 comments

Comments

@jupiter14
Copy link

@jupiter14 jupiter14 commented Jan 10, 2019

Please read the CONTRIBUTING guide before submitting an issue.

Description

Clicking on Full Screen icon on Youtube and many other video sites is not working. It does not make the video full screen.

Expected Behavior

Clicking on the Full Screen icon should enable the video in full screen mode.

Actual Behavior

Nothing happens.

Steps to Reproduce

Enabling the extension causes this problem. If the extension is disabled, the problem goes away.

Versions

Ghostery for Chrome version 8.2.6

  • Browser:
    Chrome - Version 71.0.3578.98 (Official Build) (64-bit)

  • OS:
    Window 10

  • Node:

  • NPM:

@JeremyLC
Copy link

@JeremyLC JeremyLC commented Jan 10, 2019

On YouTube you'll get this in the developer console every time you click the fullscreen button.

Failed to execute 'requestFullscreen' on 'Element': API can only be initiated by a user gesture.
zr @ base.js:1116
g.h.Gd @ base.js:4908
g.h.bH @ base.js:5907
base.js:1116 Uncaught (in promise) TypeError: fullscreen error
    at zr (base.js:1116)
    at g.BJ.g.h.Gd (base.js:4908)
    at dS.g.h.bH (base.js:5907)
zr @ base.js:1116
g.h.Gd @ base.js:4908
g.h.bH @ base.js:5907
@christophertino
Copy link
Member

@christophertino christophertino commented Jan 10, 2019

I can reproduce as well. Looks like one of our content scripts is interfering with the click event. We're currently looking into it.

@philipp-classen
Copy link
Contributor

@philipp-classen philipp-classen commented Jan 10, 2019

Looks like a duplicate of #314

@janvernieuwe
Copy link

@janvernieuwe janvernieuwe commented Jan 10, 2019

Can confirm this on Win 7 Chrome 71, it's quite annoying.
Pressing F to go fullscreen does seem to work.
Whitelisting the site does not work, only disabling the extension.

@philipp-classen
Copy link
Contributor

@philipp-classen philipp-classen commented Jan 11, 2019

@christophertino Can you please mark it as a duplicate of #314

Chrome is rolling back their experiment, which should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants