Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on blocked redirect page prevents user from following blocked redirects #376

Closed
tomclose opened this issue May 3, 2019 · 3 comments
Closed

Comments

@tomclose
Copy link

@tomclose tomclose commented May 3, 2019

Description

Error on blocked redirect page

Expected Behavior

When I click on an ad result in a google search I am taken to a ghostery page, which displays a link which I can click on if I want to display the page linked to in the ad result.

Actual Behavior

When I click on an ad result in a google search I am taken to a blank page. In the dev console the on the page I see the following errors:

Screen Shot 2019-05-03 at 11 56 19 AM

Steps to Reproduce

  1. Search for "buy a chair" or similar on google
  2. Select one of the results labelled AD

Versions

  • Browser: Google Chrome Version 74.0.3729.131 (Official Build) (64-bit)
  • OS: Mac OS Mojave (10.14.4)
  • Node: N/A
  • NPM: N/A
@shana
Copy link

@shana shana commented May 3, 2019

I'm on firefox and I'm having the same issue. sendMessageInPromise is undefined in blocked_redirect.js

e8e2bdf is this commit that broke this.

@christophertino
Copy link
Member

@christophertino christophertino commented May 9, 2019

This should be fixed in v8.3.4 which pushed to all stores today. Please update and let us know if you still see the issue.

@shana
Copy link

@shana shana commented May 16, 2019

Yup, I've confirmed it's working in 8.3.4 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants