Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: c.querySelectorAll on every page #406

Closed
AaronLavers opened this issue Jun 28, 2019 · 14 comments
Closed

Uncaught TypeError: c.querySelectorAll on every page #406

AaronLavers opened this issue Jun 28, 2019 · 14 comments
Assignees
Milestone

Comments

@AaronLavers
Copy link

@AaronLavers AaronLavers commented Jun 28, 2019

Please read the CONTRIBUTING guide before submitting an issue.

Description

When Ghostery extension is enabled in Chrome 75.0.3770.100, every page returns a massive string of identical errors:

content_script_bundle.js:16 Uncaught TypeError: c.querySelectorAll is not a function at MutationObserver.<anonymous> (content_script_bundle.js:16)

The script it's experiencing the error in appears to be related to Cliqz - which appears to be a browser that I don't have on this machine.

Expected Behavior

I'd expect these errors to not be present, before today they did not appear.

Actual Behavior

On some pages where dynamic content loads in lists, this error can duplicate itself thousands of times.

Steps to Reproduce

  1. Go to any website in Chrome with the Ghostery extension running

  2. Open console

  3. The error will be present

  4. When the plugin is paused or disabled and the page is reloaded, these errors are not present

Versions

  • Browser: Chrome Version 75.0.3770.100 (Official Build) (64-bit)
  • OS: Windows 10 Creator
@VdeJong
Copy link

@VdeJong VdeJong commented Jun 28, 2019

I get the same error on macOS Mojave and the same chrome version.

@remusao
Copy link
Contributor

@remusao remusao commented Jun 28, 2019

Hi @AaronLavers @VdeJong, thanks for your report. We were able to identify and fix this issue and we will ship it with an update ASAP.

@remusao remusao self-assigned this Jun 28, 2019
@christophertino christophertino added this to the 8.4.1 milestone Jul 2, 2019
@MarkoSulamagi
Copy link

@MarkoSulamagi MarkoSulamagi commented Jul 4, 2019

Hi @remusao. Any thoughts on when the fix will be shipped? :)

@remusao
Copy link
Contributor

@remusao remusao commented Jul 4, 2019

@MarkoSulamagi, the fix was tested and released upstream in browser-core and now needs to be shipped via a new Ghostery extension release. @christophertino will know better about the precise release schedule.

@remusao remusao assigned christophertino and unassigned remusao Jul 4, 2019
@kaiwa
Copy link

@kaiwa kaiwa commented Jul 15, 2019

I'm going to remove ghostery for now till the fix is released. I'm a web dev and can't work if errors are popping up in the console constantly.

@Jormosaurusrex
Copy link

@Jormosaurusrex Jormosaurusrex commented Jul 16, 2019

Please, please fix this. It makes my work almost impossible.

@simoozzay
Copy link

@simoozzay simoozzay commented Jul 16, 2019

Any update on the update @christophertino?
Have to agree with @kaiwa and sadly have to deactivate ghostery until the fix is released.

@christophertino
Copy link
Member

@christophertino christophertino commented Jul 17, 2019

@simoozzay We are scrambling to squeeze a few more bugs into this release and then hopefully get everything into testing tomorrow. Apologies for the delay.

@AaronLavers
Copy link
Author

@AaronLavers AaronLavers commented Jul 18, 2019

Appreciate it guys :)

@simoozzay
Copy link

@simoozzay simoozzay commented Jul 18, 2019

Thx @christophertino for the info, appreciate it! Would like to use ghostery again soon ;)
Aaand btw keep up your great work, you're doing great with ghostery. Love this tool!

@WesselKroos
Copy link

@WesselKroos WesselKroos commented Jul 18, 2019

Btw, for the webdevelopers using chrome. You can filter out the console errors in the meantime with a right click:
image

@jaewonYoon
Copy link

@jaewonYoon jaewonYoon commented Jul 29, 2019

For the frontend developer who are suffering not visible your elements,
I had same issues c.querySelectorAll is not function.....
however In my case, problem was my whole

elements has class start with 'ad' display none.
after I change class name start with keywords 'ad' to something like 'co' or 'biz'
problem fixed .

I know it's just tricky solution, but hope this might help some developers

@christophertino
Copy link
Member

@christophertino christophertino commented Aug 7, 2019

Ghostery 8.4.1 was approved and published to the Chrome store today. Please let us know if this issue is still occurring. Thanks!

@AaronLavers
Copy link
Author

@AaronLavers AaronLavers commented Aug 8, 2019

Appears to be resolved on Chrome 76.0.3809.100 (Official Build) (Win 64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
10 participants