Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusting the "localhost" site doesn't work #470

Closed
gdoron opened this issue Nov 8, 2019 · 5 comments
Closed

Trusting the "localhost" site doesn't work #470

gdoron opened this issue Nov 8, 2019 · 5 comments
Milestone

Comments

@gdoron
Copy link

@gdoron gdoron commented Nov 8, 2019

Description

I trust localhost:3000, getting OK green color. Refresh the page and my resources are back on blocked.

Versions

  • Browser: 78.0.3904.87
  • OS: MacOS
@christophertino
Copy link
Member

@christophertino christophertino commented Nov 9, 2019

It looks like the port number is messing up the whitelist URL matching. It seems to work fine with just localhost. I'll get a bug ticket made up for this.

As a suggestion to help in the meantime, you could set up Apache locally with a Reverse Proxy and give your application a test URL instead of localhost.

<VirtualHost *:80>
    DocumentRoot "PATH/TO/PROJECT"
    ProxyPass / http://localhost:3000/
    ProxyPassReverse / http://localhost:3000/
    ServerName yourdevsite.test
</VirtualHost>
@gdoron
Copy link
Author

@gdoron gdoron commented Nov 23, 2019

If you can point me to the regrex place, I'll try to fix it and open a PR.
@christophertino

@christophertino
Copy link
Member

@christophertino christophertino commented Dec 4, 2019

Thanks for the offer! Take a look at checkSiteWhitelist here

checkSiteWhitelist(url) {

I'm guessing the url parser in that function (processUrl) doesn't like localhost.

@EoinGriffin-AI
Copy link

@EoinGriffin-AI EoinGriffin-AI commented Jan 10, 2020

As a workaround until the bug is fixed, as long as you know the port number it's possible to manually enter that into the settings:
image

@benstrumeyer benstrumeyer mentioned this issue Jan 28, 2020
5 of 5 tasks complete
@christophertino christophertino added this to the 8.4.7 milestone Mar 2, 2020
@Haraldson
Copy link

@Haraldson Haraldson commented Mar 3, 2020

@EoinGriffin-AI Where’s this setting now? Or does it only apply for the Plus version?

Edit: Never mind, apparently there are two separate setting panels 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants