Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery's Purple Box is appearing in Lighthouse reports #683

Open
chrisblakley opened this issue Feb 9, 2021 · 1 comment
Open

Ghostery's Purple Box is appearing in Lighthouse reports #683

chrisblakley opened this issue Feb 9, 2021 · 1 comment

Comments

@chrisblakley
Copy link

@chrisblakley chrisblakley commented Feb 9, 2021

Description

The purple box is appearing in reports when running Lighthouse in Chrome. This is not a major issue, but it would be nice to not have the purple box influencing Lighthouse reports. I know there are many alternatives such as running Lighthouse elsewhere, using other website testers that also run Lighthouse, and/or disabling the extension from running in incognito mode, but I wanted to note this minor issue here. I also know that the CLS score increased by 0 from Ghostery, but it isn't about the score/rating, just that it is appearing.

I'm also not advocating for the purple box to be removed either. I think if it had some minor different CSS and composite animations that would do the trick to make Lighthouse stop complaining about it.

Expected Behavior

Ghostery's Purple Box would ideally not appear in Lighthouse reports.

Actual Behavior

Screen Shot 2021-02-08 at 11 58 54 PM

Note that (I believe) the "unsupported CSS property: height" is indicating that animating the height is non-composite (as opposed to, for example, animating the scaleY via a transform is composite and preferable).

Steps to Reproduce

  1. In Chrome DevTools > Lighthouse (tab) run a full report while Ghostery is enabled
  2. Likely the purple box will be noted under reports such as Cumulative Layout Shift or Composite Animations
    • Note that the way the animations, or how the purple box appears, is likely causing both issues.

Versions

  • Browser: Google Chrome 88.0
  • OS: Mac OS 11.2
@christophertino
Copy link
Member

@christophertino christophertino commented Feb 16, 2021

Thanks for the submitting. I ran a few Lighthouse reports and I see the same thing. Honestly, that purple box code is pretty old and we've been slowly phasing out that feature. I'm hesitant to start messing with the code because it's relatively stable and its been known to break websites due to CSS collisions. It would be great if there was something like @media print where we could ignore #ghostery-tracker-tally in Lighthouse but I haven't been able to find anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants