Inter-extension communication with Cliqz #101
Merged
Conversation
| .reduce((lst, val) => lst.concat(val), []) | ||
| .map(s => s.replace(/^(http[s]?:\/\/)?(www\.)?/, '')) | ||
| .filter(s => !existingSites.has(s))); | ||
| log('add whitelisted sites', [...newSites]); |
zarembsky
Jun 15, 2018
•
Contributor
Should be:
const site_whitelist;
newSites.forEach((s) => {
site_whitelist.push(s);
}
conf.site_whitelist = site_whitelist;
Setter is proxied on conf, but it reacts only changes to immediate children properties.
Should be:
const site_whitelist;
newSites.forEach((s) => {
site_whitelist.push(s);
}
conf.site_whitelist = site_whitelist;
Setter is proxied on conf, but it reacts only changes to immediate children properties.
|
sammacbeth
force-pushed the
sammacbeth:import-cliqz-settings
branch
from
c0351c0
to
d055828
|
Thanks for the comments @zarembsky. I've updated the PR to address these issues. |
christophertino
merged commit d759663
into
ghostery:develop
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is a PoC of messaging between Ghostery and Cliqz extension, allowing Ghostery to call actions on Cliqz modules.
The first use case is importing settings from the antitracking and adblocker modules in Cliqz browser, allowing for the migration of this functionality from cliqz extension to Ghostery. The Cliqz side of this communication is implemented here.
Further work is needed to define the on-boarding flow for this migration, as currently antitracking and adblocker are forced off in Cliqz browser.