Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/GH-1177 #112

Merged
merged 1 commit into from Jun 22, 2018
Merged
Changes from all commits
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

GH-1177 offer_shown fix
remove listener not needed in hot dog
  • Loading branch information
trickpattyFH20 committed Jun 22, 2018
commit 44821682827d2fce055fd1566c6fb99a8edee90d
@@ -59,7 +59,6 @@ class HotDog extends Component {
}

close() {
this.props.actions.removeFocusListener();
this.props.actions.sendSignal('offer_closed_hotdog');
if (this.iframeEl) {
this.iframeEl.classList = '';
@@ -102,6 +102,10 @@ class OfferCard extends Component {
this.props.actions.sendSignal('offer_dsp_session');
}

componentDidMount() {
this.props.actions.addRewardSeenListener();
}

copyCode() {
this.props.actions.sendSignal('code_copied');
this.offerCardRef.querySelector('.reward-code-input').select();
@@ -58,14 +58,14 @@ class RewardsApp {
this.actions = {
sendSignal: this.sendSignal,
messageBackground: this.messageBackground,
removeFocusListener: this.removeFocusListener
removeFocusListener: this.removeFocusListener,
addRewardSeenListener: this.addRewardSeenListener
};

this.init();
}

init() {
this.addRewardSeenListener();
if (document.readyState === 'complete'
|| document.readyState === 'loaded'
|| document.readyState === 'interactive'
@@ -43,6 +43,8 @@ class RewardListItem extends React.Component {
this.props.actions.sendSignal('offer_click_specific_new', id);
}
this.props.actions.sendSignal('offer_click_specific', id);
this.props.actions.sendSignal('offer_shown', id);
this.props.actions.sendSignal('offer_dsp_session', id);
}
}

ProTip! Use n and p to navigate between commits in a pull request.