Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for disabling offers from the Offers card (GH-1240) #115

Merged
merged 1 commit into from Jun 22, 2018
Merged

Fix for disabling offers from the Offers card (GH-1240) #115

merged 1 commit into from Jun 22, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Jun 22, 2018

  • [ x] Have you followed the guidelines in CONTRIBUTING.md?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [x ] Does your submission pass tests?
  • [x ] Did you lint your code prior to submission?
@zarembsky
Fix for GH-1240
Loading status checks…
480697c
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner Jun 22, 2018
@christophertino
christophertino approved these changes Jun 22, 2018
View changes
@christophertino christophertino merged commit 4a3e902 into develop Jun 22, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@trickpattyFH20
Copy link
Contributor

@trickpattyFH20 trickpattyFH20 commented Jun 23, 2018 •
edited

the pattern of signal then conf change has a potential to produce a race condition with the offers-v2 module flushSignals functionality. not critical, but should be addressed in a minor version release
@zarembsky zarembsky deleted the feature/disableOffers branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zarembsky @trickpattyFH20 @christophertino