Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Offers #116

Merged
merged 4 commits into from Jun 26, 2018
Merged

Fixes for Offers #116

merged 4 commits into from Jun 26, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Jun 26, 2018

  • [ x] Have you followed the guidelines in CONTRIBUTING.md?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [ x] Have you added an explanation of what your changes do?
  • [ x] Does your submission pass tests?
  • [x ] Did you lint your code prior to submission?
@zarembsky
Different fixes.
Loading status checks…
51e4e69
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner Jun 26, 2018
zarembsky added 3 commits Jun 26, 2018
@zarembsky
Restoring yarn.lock
Loading status checks…
001fc80
@zarembsky
Introducing new browser-core package.
Loading status checks…
45c1895
@zarembsky
Lint complains
Loading status checks…
7911eeb
@christophertino christophertino requested a review from IAmThePan Jun 26, 2018
@IAmThePan
IAmThePan approved these changes Jun 26, 2018
View changes
Copy link
Contributor

@IAmThePan IAmThePan left a comment

approved
@christophertino christophertino merged commit 02ab0c3 into develop Jun 26, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@IAmThePan IAmThePan deleted the feature/offersFixes branch Jun 26, 2018
@benstrumeyer benstrumeyer mentioned this pull request Apr 23, 2020
Merged
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmThePan IAmThePan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zarembsky @IAmThePan @christophertino