Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Offers #116

Merged
merged 4 commits into from Jun 26, 2018
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev
Lint complains
  • Loading branch information
zarembsky committed Jun 26, 2018
commit 7911eebc4761f286287995e65165fe11fb229baf
@@ -65,6 +65,7 @@ class Notification extends Component {
className="notification-text"
href={this.props.data.textLink.href}
target="_blank"
rel="noopener noreferrer"
onClick={() => {
if (this.props.data.textLink.callback) {
this.props.data.textLink.callback();
@@ -279,7 +279,7 @@ class OfferCard extends Component {
</div>
}
</div>
<a target="_blank" onClick={this.redeem} href={this.state.rewardUI.call_to_action && this.state.rewardUI.call_to_action.url} className="reward-redeem">
<a target="_blank" rel="noopener noreferrer" onClick={this.redeem} href={this.state.rewardUI.call_to_action && this.state.rewardUI.call_to_action.url} className="reward-redeem">
{this.state.rewardUI.call_to_action.text}
</a>
</div>
@@ -43,7 +43,7 @@ class License extends React.Component {
return (
<div className="license">
<div>{`${t('license_module')}: ${license.name}`}</div>
<a href={license.repository} target="_blank"><span style={{ color: '#4A4A4A' }}>{`${t('license_repository')}:`}</span>{` ${license.repository || t('license_information_missing')}`}</a>
<a href={license.repository} target="_blank" rel="noopener noreferrer"><span style={{ color: '#4A4A4A' }}>{`${t('license_repository')}:`}</span>{` ${license.repository || t('license_information_missing')}`}</a>
<div>{`${t('license_type')}: ${license.licenses}`}</div>
<div>{`${t('license_publisher')}: ${license.publisher || t('license_unknown')}`}</div>
<div>{`${t('license_url')}: ${license.url || t('license_unknown')}`}</div>
@@ -111,7 +111,7 @@ class GlobalTracker extends React.Component {
{
this.state.showTrackerLearnMore &&
<div className={(!this.state.showTrackerLearnMore ? 'hide' : '')}>
<a target="_blank" title={tracker.name} href={`https://${globals.APPS_SUB_DOMAIN}.ghostery.com/${this.props.language}/apps/${encodeURIComponent(tracker.name.replace(/\s+/g, '_').toLowerCase())}`}>
<a target="_blank" rel="noopener noreferrer" title={tracker.name} href={`https://${globals.APPS_SUB_DOMAIN}.ghostery.com/${this.props.language}/apps/${encodeURIComponent(tracker.name.replace(/\s+/g, '_').toLowerCase())}`}>
{ t('tracker_description_learn_more') }
</a>
</div>
@@ -210,6 +210,7 @@ class Tracker extends React.Component {
sources = tracker.sources.map((source, index) => (
<a
target="_blank"
rel="noopener noreferrer"
className="trk-src-link"
title={source.src}
key={index}
@@ -285,7 +286,7 @@ class Tracker extends React.Component {
<div className="trk-description">
{ this.state.description }
<div className={(!this.state.showTrackerLearnMore ? 'hide' : '')}>
<a target="_blank" title={tracker.name} href={`https://${globals.APPS_SUB_DOMAIN}.ghostery.com/${this.props.language}/apps/${encodeURIComponent(tracker.name.replace(/\s+/g, '_').toLowerCase())}`}>
<a target="_blank" rel="noopener noreferrer" title={tracker.name} href={`https://${globals.APPS_SUB_DOMAIN}.ghostery.com/${this.props.language}/apps/${encodeURIComponent(tracker.name.replace(/\s+/g, '_').toLowerCase())}`}>
{ t('tracker_description_learn_more') }
</a>
</div>
ProTip! Use n and p to navigate between commits in a pull request.