Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for enabling offers on upgrade and for Setup data sharing checkboxes. #117

Merged
merged 3 commits into from Jun 27, 2018
Merged

Fixes for enabling offers on upgrade and for Setup data sharing checkboxes. #117

merged 3 commits into from Jun 27, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Jun 27, 2018

  • [x ] Have you followed the guidelines in CONTRIBUTING.md?
  • [ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [ x] Does your submission pass tests?
  • [x ] Did you lint your code prior to submission?
zarembsky added 3 commits Jun 27, 2018
@zarembsky
Deleting offer_enabled value.
Loading status checks…
8602c1b
@zarembsky
Fix for Setup checkbox.
54f19b3
@zarembsky
Extra fix for enabling offers on upgrade.
Loading status checks…
1db187f
@zarembsky zarembsky changed the base branch from master to develop Jun 27, 2018
@IAmThePan
IAmThePan approved these changes Jun 27, 2018
View changes
Copy link
Contributor

@IAmThePan IAmThePan left a comment

Looks good. @christophertino pleas approve, build and send Production Build to Germany for testing.
@christophertino
christophertino approved these changes Jun 27, 2018
View changes
@christophertino christophertino merged commit 8c4491d into develop Jun 27, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@zarembsky zarembsky deleted the feature/upgrade branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmThePan IAmThePan

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zarembsky @IAmThePan @christophertino