Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respecting user choice on Offers plus removing Edge-specific key from manifest plus fixing vertical blank (GH-1244, GH-1199, GH-1236) #119

Merged
merged 2 commits into from Jul 5, 2018
Merged

Respecting user choice on Offers plus removing Edge-specific key from manifest plus fixing vertical blank (GH-1244, GH-1199, GH-1236) #119

merged 2 commits into from Jul 5, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Jul 3, 2018

  • [x ] Have you followed the guidelines in CONTRIBUTING.md?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [x ] Does your submission pass tests?
  • [ x] Did you lint your code prior to submission?
@zarembsky
Fix for respecting user choice plus removing manifest Edge-specific key.
Loading status checks…
6a4b965
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner Jul 3, 2018
@zarembsky
Fix for vertical blank (GH-1236)
Loading status checks…
6375745
@zarembsky zarembsky changed the title Respecting user choice on Offers plus removing Edge-specific key from manifest (GH-1236, GH-1199) Respecting user choice on Offers plus removing Edge-specific key from manifest plus fixing vertical blank (GH-1244, GH-1199, GH-1236) Jul 5, 2018
@christophertino
christophertino approved these changes Jul 5, 2018
View changes
@christophertino christophertino merged commit ad11714 into develop Jul 5, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@zarembsky zarembsky deleted the feature/respectOffers branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@zarembsky @christophertino