Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1239 Tracker count respects SmartBlock block/unblock #123

Merged
merged 3 commits into from Jul 5, 2018

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Jul 5, 2018

Make the total Tracker Count respect the SmartBlock block/unblock numbers

@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner Jul 5, 2018
@IAmThePan
Copy link
Contributor Author

@IAmThePan IAmThePan commented Jul 5, 2018

Vinny doesn't want this. Maybe we will do this when we also incorporate Anti-Tracking and Ad-Blocking into the Total Trackers Blocked count. Saving this code for later.

@IAmThePan IAmThePan closed this Jul 5, 2018
@IAmThePan IAmThePan reopened this Jul 5, 2018
@IAmThePan
Copy link
Contributor Author

@IAmThePan IAmThePan commented Jul 5, 2018

Actually we do want this PR
@christophertino please approve

@christophertino christophertino merged commit d5d26e1 into develop Jul 5, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the feature/gh-1239 branch Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants