Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1177 Updates to signals #124

Merged
merged 1 commit into from Jul 5, 2018
Merged
Changes from all commits
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

GH-1177 Updates to signals
Move signal to constructor
  • Loading branch information
IAmThePan committed Jul 2, 2018
commit bc1fb8ffbb1fc2a48de0b3cbdcc7e3a26e2bf1a0
@@ -28,6 +28,9 @@ class RewardListItem extends React.Component {
// Event Bindings
this.handleClick = this.handleClick.bind(this);
this.clickCloseButton = this.clickCloseButton.bind(this);

// Send Signal
this.props.actions.sendSignal('offer_shown', this.props.id);
}

/**
@@ -43,7 +46,6 @@ class RewardListItem extends React.Component {
this.props.actions.sendSignal('offer_click_specific_new', id);
}
this.props.actions.sendSignal('offer_click_specific', id);
this.props.actions.sendSignal('offer_shown', id);
this.props.actions.sendSignal('offer_dsp_session', id);
}
}
@@ -55,6 +57,7 @@ class RewardListItem extends React.Component {
clickCloseButton(event) {
// Prevent the event from propagating and linking to the Reward Detail
event.preventDefault();
event.stopPropagation();

const { id } = this.props;
this.props.actions.removeOffer(id);
ProTip! Use n and p to navigate between commits in a pull request.