Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1247 close settings menu #125

Merged
merged 3 commits into from Jul 6, 2018
Merged

GH-1247 close settings menu #125

merged 3 commits into from Jul 6, 2018

Conversation

@trickpattyFH20
Copy link
Contributor

@trickpattyFH20 trickpattyFH20 commented Jul 6, 2018 •
edited

non standard event.path was breaking "click outside" logic in some browsers
@trickpattyFH20
GH-1247 - fix for non standard event path
Loading status checks…
2035abb
@trickpattyFH20
fix iframe click outside
Loading status checks…
118d85b
@trickpattyFH20 trickpattyFH20 requested a review from ghostery/ghostery as a code owner Jul 6, 2018
@christophertino
christophertino approved these changes Jul 6, 2018
View changes
@christophertino
Merge branch 'develop' into feature/GH-1247
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
a6bf44d
@christophertino christophertino merged commit fece26a into develop Jul 6, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the feature/GH-1247 branch Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@trickpattyFH20 @christophertino