Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1247 close settings menu #125

Merged
merged 3 commits into from Jul 6, 2018
Merged
Changes from all commits
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

@@ -42,6 +42,7 @@ class OfferCard extends Component {

this.iframeEl = window.parent.document.getElementById('ghostery-iframe-container');
if (this.iframeEl) {
this.iframeContentDocument = this.iframeEl.contentDocument;
this.iframeEl.classList = '';
this.iframeEl.classList.add('offer-card');
}
@@ -237,7 +238,7 @@ class OfferCard extends Component {
/>
{ this.state.showSettings &&
<div className="rewards-settings-container">
<ClickOutside excludeEl={this.kebabRef} onClickOutside={this.toggleSettings}>
<ClickOutside excludeEl={this.kebabRef} onClickOutside={this.toggleSettings} offsetParent={this.iframeContentDocument}>
<Settings signal={() => { this.props.actions.sendSignal('about_ghostery_rewards', false); }} disable={this.disableRewardsNotification} />
</ClickOutside>
</div>
@@ -24,18 +24,19 @@ class ClickOutside extends React.Component {
// event bindings
this.getContainer = this.getContainer.bind(this);
this.clickHandler = this.clickHandler.bind(this);
this.listenerEl = this.props.offsetParent || document;
}
/**
* Lifecycle event. Set 'click' event listener
*/
componentDidMount() {
document.addEventListener('click', this.clickHandler, true);
this.listenerEl.addEventListener('click', this.clickHandler, true);
}
/**
* Lifecycle event. Remove 'click' event listener
*/
componentWillUnmount() {
document.removeEventListener('click', this.clickHandler, true);
this.listenerEl.removeEventListener('click', this.clickHandler, true);
}
/**
* Set designated component which has ref attribute
@@ -51,10 +52,13 @@ class ClickOutside extends React.Component {
*/
clickHandler(e) {
const el = this.container;
if (!el.contains(e.target)
&& !el.contains(e.path[0])
const ePath = e.path || (e.composedPath && e.composedPath());
if (
!el.contains(e.target)
&& e.target !== this.props.excludeEl
&& e.path[0] !== this.props.excludeEl) {
&& !el.contains(ePath[0])
&& ePath[0] !== this.props.excludeEl
) {
this.props.onClickOutside(e);
}
}
ProTip! Use n and p to navigate between commits in a pull request.