Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in reporting of the offers enabled state (GH-1260) #128

Merged
merged 2 commits into from Jul 10, 2018
+2 −2
Merged

Bug in reporting of the offers enabled state (GH-1260) #128

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f0086
Fix for GH-1260 (erroneous reporting of offers state)
zarembsky Jul 10, 2018
16e72c2
Merge branch 'develop' into feature/offersAB
christophertino Jul 10, 2018
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next
Loading status checks…
Fix for GH-1260 (erroneous reporting of offers state)
  • Loading branch information
@zarembsky
zarembsky committed Jul 10, 2018
commit d8f0086134a031e85ede849bce18c4a917076a93
4 src/classes/Metrics.js
View file
Open in desktop
@@ -224,7 +224,7 @@ class Metrics {
let metrics_url = `https://${METRICS_SUB_DOMAIN}.ghostery.com/${type}${frequencyString}?gr=-1` +
// Old parameters, old names
// Human web
`&hw=${encodeURIComponent(IS_EDGE ? '0' : (conf.enable_human_web ? '1' : '0'))}` +
`&hw=${encodeURIComponent(conf.enable_human_web ? '1' : '0')}` +
// Extension version
`&v=${encodeURIComponent(EXTENSION_VERSION)}` +
// User agent - browser
@@ -238,7 +238,7 @@ class Metrics {

// Old parameters, new names
// Offers (former offers)
`&of=${encodeURIComponent(IS_EDGE ? '0' : ((conf.enable_offers && abtest.hasTest('offers')) ? '1' : '0'))}` +
`&of=${encodeURIComponent(conf.enable_offers ? '1' : '0')}` +
// Random number, assigned at install (former install_rand)
`&ir=${encodeURIComponent(conf.install_random_number)}` +
// Login state (former signed_in)
ProTip! Use n and p to navigate between commits in a pull request.