Fix for Edge Setup trouble (GH-1261) #134

zarembsky · 2018-07-12T21:49:13Z

[ x] Have you followed the guidelines in CONTRIBUTING.md?
[ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ x] Have you added an explanation of what your changes do?
[ x] Does your submission pass tests?
[x ] Did you lint your code prior to submission?

christophertino · 2018-07-12T22:26:31Z

src/background.js

@@ -1548,6 +1544,7 @@ function initializeGhosteryModules() {
 */
 function init() {
 	return confData.init().then(() => {
+		panelData.init();


@zarembsky remove this

Fix for Edge Setup trouble

Loading status checks…

85ea01e

zarembsky requested a review from christophertino Jul 12, 2018

Lint errors

Loading status checks…

2005f4b

christophertino reviewed Jul 12, 2018

View changes

src/background.js Outdated

@@ -1548,6 +1544,7 @@ function initializeGhosteryModules() {

*/

function init() {

return confData.init().then(() => {

panelData.init();

This comment has been minimized.

Sign in to view

christophertino Jul 12, 2018
Member

@zarembsky remove this

Removed extra panelData.init

Loading status checks…

6812740

christophertino approved these changes Jul 12, 2018

View changes

christophertino merged commit ba07d98 into develop Jul 12, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

continuous-integration/travis-ci/push The Travis CI build passed
Details

christophertino deleted the feature/edgeSetup branch Jul 12, 2018

ghostery / ghostery-extension

Fix for Edge Setup trouble (GH-1261) #134

Fix for Edge Setup trouble (GH-1261) #134

zarembsky commented Jul 12, 2018

This comment has been minimized.

ghostery / ghostery-extension

Fix for Edge Setup trouble (GH-1261) #134

Fix for Edge Setup trouble (GH-1261) #134

Conversation

zarembsky commented Jul 12, 2018

This comment has been minimized.

christophertino Jul 12, 2018 Member

christophertino Jul 12, 2018
Member