Counter incorrect with no trackers but ads blocked #136
Conversation
…other trackers on page
IAmThePan
requested review from
jsignanini,
zarembsky and
ghostery/ghostery
as
code owners
christophertino
merged commit 751efc7
into
ghostery:develop
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix issue with the button counter when the adBlocker finds an ad but no other trackers on page resulting in the button reporting 0 but the panel reporting 1 (or more)