Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refining onBeforeRequest handler to minimize the number of requests without corresponding page url. #138

Merged
merged 10 commits into from Aug 2, 2018
Merged

Refining onBeforeRequest handler to minimize the number of requests without corresponding page url. #138

merged 10 commits into from Aug 2, 2018

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Jul 16, 2018

  • [x ] Have you followed the guidelines in CONTRIBUTING.md?
  • [ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [x ] Does your submission pass tests?
  • [x ] Did you lint your code prior to submission?
zarembsky added 2 commits Jul 16, 2018
@zarembsky
Refining onBeforeRequest handler.
23d36e2
@zarembsky
Lint errors
Loading status checks…
0a6568c
@zarembsky zarembsky requested review from jsignanini and ghostery/ghostery as code owners Jul 16, 2018
zarembsky and others added 8 commits Jul 17, 2018
@zarembsky
Delaying tabInfo removal.
Loading status checks…
64ba128
@jsignanini
Refactor logic.
Loading status checks…
c90329d
@zarembsky
Adjusted TabInfo
3d69d6c
@zarembsky
Lint complained.
Loading status checks…
e4e85fc
@jsignanini
Merge branch 'develop' into feature/beforeRequest
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
5451a4e
@christophertino
Merge branch 'develop' into feature/beforeRequest
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3567200
@jsignanini
Merge branch 'develop' into feature/beforeRequest
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
d41adab
@jsignanini
Remove onTabRemoved delay to avoid potential memory leaks.
Loading status checks…
d6e7768
@jsignanini
jsignanini approved these changes Aug 2, 2018
View changes
@jsignanini jsignanini merged commit 00c72bd into develop Aug 2, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/beforeRequest branch Aug 2, 2018
jsignanini added a commit that referenced this pull request Aug 21, 2018
@zarembsky @jsignanini
Refining onBeforeRequest handler to minimize the number of requests w…
a5b79a7 
…ithout corresponding page url. (#138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zarembsky @jsignanini @christophertino