Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refining onBeforeRequest handler to minimize the number of requests without corresponding page url. #138

Merged
merged 10 commits into from Aug 2, 2018
+12 −12
Merged

Refining onBeforeRequest handler to minimize the number of requests without corresponding page url. #138

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
23d36e2
Refining onBeforeRequest handler.
zarembsky Jul 16, 2018
0a6568c
Lint errors
zarembsky Jul 16, 2018
64ba128
Delaying tabInfo removal.
zarembsky Jul 17, 2018
c90329d
Refactor logic.
jsignanini Jul 24, 2018
3d69d6c
Adjusted TabInfo
zarembsky Jul 24, 2018
e4e85fc
Lint complained.
zarembsky Jul 24, 2018
5451a4e
Merge branch 'develop' into feature/beforeRequest
jsignanini Jul 24, 2018
3567200
Merge branch 'develop' into feature/beforeRequest
christophertino Jul 25, 2018
d41adab
Merge branch 'develop' into feature/beforeRequest
jsignanini Aug 2, 2018
d6e7768
Remove onTabRemoved delay to avoid potential memory leaks.
jsignanini Aug 2, 2018
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…
Lint errors
  • Loading branch information
@zarembsky
zarembsky committed Jul 16, 2018
commit 0a6568cd3f94d798e4b00e806b964499a7b2c71d
26 src/classes/EventHandlers.js
View file
Open in desktop
@@ -335,26 +335,26 @@ class EventHandlers {
return { cancel: false };
}

if(details.type === 'main_frame') {
if(!tabInfo.getTabInfo(tab_id)) {
if (details.type === 'main_frame') {
if (!tabInfo.getTabInfo(tab_id)) {
tabInfo.create(tab_id, details.url);
} else {
tabInfo.setTabInfo(tab_id, 'url', details.url);
}
}
}

if(!tabInfo.getTabInfo(tab_id)) {
if (!tabInfo.getTabInfo(tab_id)) {
utils.getTab(tab_id, (tab) => {
if(!tabInfo.getTabInfo(tab_id)) {
tabInfo.create(tab_id, tab.url);
} else {
tabInfo.setTabInfo(tab_id, 'url', tab.url);
}
tabInfo.setTabInfo(tab_id, 'incognito', tab.incognito);
},
error => {
log("TAB CANNOT BE QUERIED", error, tabInfo.getTabInfo(tab_id));
if (!tabInfo.getTabInfo(tab_id)) {
tabInfo.create(tab_id, tab.url);
} else {
tabInfo.setTabInfo(tab_id, 'url', tab.url);
}
tabInfo.setTabInfo(tab_id, 'incognito', tab.incognito);
},
(error) => {
log('TAB CANNOT BE QUERIED', error, tabInfo.getTabInfo(tab_id));
}
);
}

ProTip! Use n and p to navigate between commits in a pull request.