Restored abtest.fetch call at startup. #145

zarembsky · 2018-07-23T15:47:52Z

[x ] Have you followed the guidelines in CONTRIBUTING.md?
[ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x ] Have you added an explanation of what your changes do?
[ x] Does your submission pass tests?
[x ] Did you lint your code prior to submission?

jsignanini · 2018-07-24T14:26:39Z

src/background.js

+			}).catch((err) => {
+				log('cliqzStartup abtest fetch error', err);
+			});
+		}


@zarembsky it looks like this (and adding the cmp.fetchCMPData() call is the exact same code as what's in schueduledTasks()... should we just call that function in here instead? (And remove the cmp.fetchCMPData() call

Yes we can. I'll make the change.

Restored abtest.fetch call at startup.

Loading status checks…

c541263

zarembsky requested a review from jsignanini Jul 23, 2018

jsignanini requested changes Jul 24, 2018

View changes

zarembsky and others added 3 commits Jul 24, 2018

Using scheduledTasks.

Loading status checks…

1a37d70

Merge branch 'develop' into feature/abtestBack

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.

Loading status checks…

464dbd1

Add comment.

Loading status checks…

7ab5836

jsignanini approved these changes Jul 24, 2018

View changes

jsignanini merged commit 56d3f98 into develop Jul 24, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

continuous-integration/travis-ci/push The Travis CI build passed
Details

jsignanini deleted the feature/abtestBack branch Jul 24, 2018

ghostery / ghostery-extension

Restored abtest.fetch call at startup. #145

Restored abtest.fetch call at startup. #145

zarembsky commented Jul 23, 2018

This comment has been minimized.

This comment has been minimized.

ghostery / ghostery-extension

Restored abtest.fetch call at startup. #145

Restored abtest.fetch call at startup. #145

Conversation

zarembsky commented Jul 23, 2018

This comment has been minimized.

jsignanini Jul 24, 2018 Member

This comment has been minimized.

zarembsky Jul 24, 2018 Author Contributor

jsignanini Jul 24, 2018
Member

zarembsky Jul 24, 2018
Author Contributor