Fix for GH-872, "Not Scanned" case. #15
Merged
Conversation
Contributor
zarembsky
commented
Mar 28, 2018
|
added 2 commits
Mar 26, 2018
src/classes/PanelData.js
Outdated
| @@ -348,7 +348,7 @@ class PanelData { | |||
| .set('pageHost', pageHost) | |||
| .set('performanceData', tab && tabInfo.getTabInfo(tab_id, 'pageTiming')) | |||
| .set('sitePolicy', tab && policy.getSitePolicy(tab_url) || false) | |||
| .set('siteNotScanned', tab && !foundBugs.getApps(tab_id) || false) | |||
| .set('siteNotScanned', tab && !trackerList.length || false) | |||
| .set('tab_id', tab_id) | |||
jsignanini
Mar 30, 2018
Member
@zarembsky foundBugs.getApps() returns 3 states, false for page not scanned, [] for page scanned but found no trackers, and [tracker, tracker, ...] for page scanned and trackers were found. So we should leave this as it was.
@zarembsky foundBugs.getApps() returns 3 states, false for page not scanned, [] for page scanned but found no trackers, and [tracker, tracker, ...] for page scanned and trackers were found. So we should leave this as it was.
app/content-scripts/notifications.js
Outdated
| @@ -733,6 +733,9 @@ const NotificationsContentScript = (function (win, doc) { | |||
| ]; | |||
| const { name } = request; | |||
| const reqMsg = request.message; | |||
| if (!reqMsg) { | |||
| return false; | |||
| } | |||
|
@zarembsky please address the comment I originally posted about finding out why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.