Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GH-872, "Not Scanned" case. #15

Merged
merged 5 commits into from Apr 3, 2018
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next

Added checks for non-null message

  • Loading branch information
Serge Zarembsky
Serge Zarembsky committed Mar 26, 2018
commit 587568edfe6da65c6ec261b06cb3cdbfd3b99dbe
@@ -164,6 +164,10 @@ const Click2PlayContentScript = (function (win, doc) {
const { name } = request;
const reqMsg = request.msg;

if(!reqMsg) {
return false;
}

log('click_to_play.js received message', name);

if (name === 'c2p') {
@@ -733,6 +733,9 @@ const NotificationsContentScript = (function (win, doc) {
];
const { name } = request;
const reqMsg = request.message;
if(!reqMsg) {
return false;
}

This comment has been minimized.

@jsignanini

jsignanini Mar 30, 2018
Member

@zarembsky let's investigate why request.message is coming in as undefined here.


log('notifications.js received message', name);

ProTip! Use n and p to navigate between commits in a pull request.