Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 1300 translation for popup #151

Merged
merged 5 commits into from Aug 7, 2018
Merged

Gh 1300 translation for popup #151

merged 5 commits into from Aug 7, 2018

Conversation

@aleksandr-cliqz
Copy link
Contributor

@aleksandr-cliqz aleksandr-cliqz commented Aug 2, 2018

  • yarn run test.unit
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

https://cliqztix.atlassian.net/browse/GH-1300
i added translation for this popup https://cliqztix.atlassian.net/browse/EX-7693

@eleniS @zhonghao-cliqz
aleksandr panin added 2 commits Aug 2, 2018
aleksandr panin
GH-1300 translations
3defc71
aleksandr panin
GH-1300 fix ident
Loading status checks…
39a82b7
@aleksandr-cliqz aleksandr-cliqz requested a review from ghostery/ghostery as a code owner Aug 2, 2018
@christophertino
christophertino approved these changes Aug 6, 2018
View changes
Copy link
Member

@christophertino christophertino left a comment •
edited

@aleksandr-cliqz please only include the strings for en and de language files. The rest will be created by Transfix and default to en for the time being.
@christophertino
christophertino requested changes Aug 6, 2018
View changes
Copy link
Member

@christophertino christophertino left a comment

pending removal of language strings except DE and EN
christophertino and others added 2 commits Aug 6, 2018
@christophertino
Merge branch 'develop' into GH-1300_translation_for_popup
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
7e9c767
aleksandr panin
GH-1300 remove unnecessary translations
Loading status checks…
d2c6d9b
@aleksandr-cliqz
Copy link
Contributor Author

@aleksandr-cliqz aleksandr-cliqz commented Aug 7, 2018

@christophertino done)
@christophertino
Merge branch 'develop' into GH-1300_translation_for_popup
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
d1139d6
@christophertino
christophertino approved these changes Aug 7, 2018
View changes
@christophertino christophertino merged commit 4bab24e into ghostery:develop Aug 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jsignanini added a commit that referenced this pull request Aug 21, 2018
@aleksandr-cliqz @jsignanini
GH -300 translations for rewards popup (#151)
abacec4 
* GH-1300 translations

* GH-1300 fix ident

* GH-1300 remove unnecessary translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@aleksandr-cliqz @christophertino