Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing hanging on startup (gh-1314) #156

Closed
wants to merge 17 commits into from
Closed

Fixing hanging on startup (gh-1314) #156

wants to merge 17 commits into from

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Aug 10, 2018

  • [x ] Have you followed the guidelines in CONTRIBUTING.md?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • [x ] Did you lint your code prior to submission?
zarembsky added 16 commits Jun 20, 2018
@zarembsky
Adding performance changes
Loading status checks…
d42ae1d
@zarembsky
Added PerfResults file
ad41263
@zarembsky
New results
Loading status checks…
8f122ef
@zarembsky
Sending Ghostery version
Loading status checks…
e3282d6
@zarembsky
Providing static info.
Loading status checks…
0589432
@zarembsky
Merge remote-tracking branch 'remotes/origin/develop' into feature/Perf
Loading status checks…
4facaa4
@zarembsky
Merge remote-tracking branch 'remotes/origin/develop' into feature/Perf
Loading status checks…
e58edbc
@zarembsky
Adding request type to the data being sent.
09bbfa4
@zarembsky
Merge branch 'develop' into feature/Perf
Loading status checks…
9f35377
@zarembsky
Merge branch 'develop' into feature/Perf
25e505a
@zarembsky
Moving static info code to Ghostery
Loading status checks…
7228814
@zarembsky
making ghostery-perf id a key in manifest.
Loading status checks…
9153674
@zarembsky
Merge branch 'develop' into feature/Perf
Loading status checks…
18a3c83
@zarembsky
Improving startup code.
Loading status checks…
ffd871b
@zarembsky
Fix for hanging GH-1314
Loading status checks…
87bce18
@zarembsky
Merge branch 'develop' into feature/hanging
Loading status checks…
6fa5779 
# Conflicts:
#	src/classes/Account.js
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner Aug 10, 2018
@jsignanini
Merge branch 'develop' into feature/hanging
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
aeb6b9a
@zarembsky zarembsky closed this Aug 21, 2018
@zarembsky zarembsky deleted the feature/hanging branch Aug 21, 2018
@zarembsky
Copy link
Contributor Author

@zarembsky zarembsky commented Aug 21, 2018

Suggested approach does not work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostery/ghostery Ghostery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@zarembsky @jsignanini