GH-1287 readstate ff fix #157
Merged
Conversation
Contributor
trickpattyFH20
commented
Aug 13, 2018
|
| @@ -190,9 +187,9 @@ class RewardsApp { | |||
| this.reward = request.reward; | |||
| this.conf = request.conf; | |||
| } | |||
| if (document.readyState === 'complete' || document.readyState === 'interactive') { | |||
| setTimeout(() => { | |||
trickpattyFH20
Aug 14, 2018
•
Author
Contributor
React sees the element as non interactive and overwrites the click handlers. I added an inline comment documenting the setTimeout workaround
React sees the element as non interactive and overwrites the click handlers. I added an inline comment documenting the setTimeout workaround
…ery-extension into feature/close-rewards-fix
jsignanini
added a commit
that referenced
this pull request
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.