Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1318 logout sync - remove cookie change event #158

Merged
merged 4 commits into from Aug 14, 2018

Conversation

@trickpattyFH20
Copy link
Contributor

@trickpattyFH20 trickpattyFH20 commented Aug 13, 2018

remove the cookie change event that handles logout syncing from account-web to the extension.
cookie change event produces unexpected results in FF.
instead, use custom event in account-web PR #3 and call account.logout from the content script

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@trickpattyFH20 trickpattyFH20 requested review from zarembsky and ghostery/ghostery as code owners Aug 13, 2018
trickpattyFH20 and others added 2 commits Aug 13, 2018
@jsignanini jsignanini merged commit 6e3147d into develop Aug 14, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@jsignanini jsignanini deleted the feature/GH-1318-logout-sync branch Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants