Ghostery Hub - Custom Setup Workflow #164
Merged
Conversation
IAmThePan
requested review from
trickpattyFH20,
zarembsky and
ghostery/ghostery
as
code owners
|
@IAmThePan let's replace all action types with string |
|
@IAmThePan Let's also put the Component's test files under a |
|
…try modal for reset settings confirmation Reorganize components, build SetupView component and container with tests Update SetupHeader and SetupBlockingView css html and tests, stub out other Setup flow components Update Custom Setup Flow. ToDo: Custom Blocking, Modals, 404 page, Constants, Integration Tests Fix linting errors Fix linting errors ii Create setup flow modal. Implement exit button Add Modal. Changes from Jira ticket Logic for showing the Modal upon entering Setup Flow Update links to point to hub.html instead of setup.html Move hub tests into __tests__ folders. Use constants instead of strings. Missed constant-izing two strings Remove event bindings in favor of named arrow functions Constant-ize tutorial action string. Update import of sendMessageInPromise Remove ClassNames from Modal Remove non-internationalized string placeholders from scaffolded views
jsignanini
added a commit
that referenced
this pull request
Nov 20, 2018
…try modal for reset settings confirmation (#164) Reorganize components, build SetupView component and container with tests Update SetupHeader and SetupBlockingView css html and tests, stub out other Setup flow components Update Custom Setup Flow. ToDo: Custom Blocking, Modals, 404 page, Constants, Integration Tests Fix linting errors Fix linting errors ii Create setup flow modal. Implement exit button Add Modal. Changes from Jira ticket Logic for showing the Modal upon entering Setup Flow Update links to point to hub.html instead of setup.html Move hub tests into __tests__ folders. Use constants instead of strings. Missed constant-izing two strings Remove event bindings in favor of named arrow functions Constant-ize tutorial action string. Update import of sendMessageInPromise Remove ClassNames from Modal Remove non-internationalized string placeholders from scaffolded views
jsignanini
added a commit
that referenced
this pull request
Nov 20, 2018
…try modal for reset settings confirmation (#164) Reorganize components, build SetupView component and container with tests Update SetupHeader and SetupBlockingView css html and tests, stub out other Setup flow components Update Custom Setup Flow. ToDo: Custom Blocking, Modals, 404 page, Constants, Integration Tests Fix linting errors Fix linting errors ii Create setup flow modal. Implement exit button Add Modal. Changes from Jira ticket Logic for showing the Modal upon entering Setup Flow Update links to point to hub.html instead of setup.html Move hub tests into __tests__ folders. Use constants instead of strings. Missed constant-izing two strings Remove event bindings in favor of named arrow functions Constant-ize tutorial action string. Update import of sendMessageInPromise Remove ClassNames from Modal Remove non-internationalized string placeholders from scaffolded views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Stubbed out the new Ghostery Hub
Created the new Custom Setup Workflow (GH-1012)