Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conf / panel data setting enable_offers and signal sent #165

Merged
merged 2 commits into from Aug 20, 2018
Merged

fix conf / panel data setting enable_offers and signal sent #165

merged 2 commits into from Aug 20, 2018

Conversation

@trickpattyFH20
Copy link
Contributor

@trickpattyFH20 trickpattyFH20 commented Aug 17, 2018

No description provided.

@trickpattyFH20
fix conf / panel data setting enable_offers and signal sent
Loading status checks…
fe4f4d9
@trickpattyFH20 trickpattyFH20 requested review from zarembsky and ghostery/ghostery as code owners Aug 17, 2018
@trickpattyFH20 trickpattyFH20 requested a review from jsignanini Aug 17, 2018
@jsignanini
jsignanini requested changes Aug 20, 2018
View changes
Copy link
Member

@jsignanini jsignanini left a comment •
edited

@trickpattyFH20 I'm still seeing the rewards toggle not persist my choice:

  1. Install ghostery
  2. Navigate to any website
  3. Open panel > Detailed View > Rewards Tab > Toggle Rewards to OFF position > Close Panel
  4. Open panel again, Rewards Toggle goes back to ON position
@trickpattyFH20
fix hub toggle offers logic
Loading status checks…
a4046ad
@trickpattyFH20
Copy link
Contributor Author

@trickpattyFH20 trickpattyFH20 commented Aug 20, 2018

@jsignanini updated with fix for toggling from hub
@jsignanini
jsignanini approved these changes Aug 20, 2018
View changes
@jsignanini jsignanini merged commit 0d2757a into release/8.2.4 Aug 20, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/GH-1335 branch Aug 20, 2018
jsignanini added a commit that referenced this pull request Aug 21, 2018
@trickpattyFH20 @jsignanini
fix conf / panel data setting enable_offers and signal sent (#165)
Loading status checks…
ee1f399
jsignanini added a commit that referenced this pull request Aug 22, 2018
@trickpattyFH20 @jsignanini
fix conf / panel data setting enable_offers and signal sent (#165)
3c23e05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@trickpattyFH20 @jsignanini