hub home and side navigation #167
Closed
+2,126
−417
Conversation
|
How about fancy one-liner in componentWillMount: |
|
@zarembsky these should also be moved to the constructor since |
trickpattyFH20
force-pushed the
feature/hub-home
branch
2 times, most recently
from
12f154d
to
ab62b39
app/hub/Views/HomeView/HomeView.jsx
Outdated
| return <div>{title}</div>; | ||
| return ( | ||
| <div> | ||
| {title} |
| export default TutorialTrustRestrictView; | ||
| export function toggleAnalytics(data) { | ||
| return { | ||
| type: 'TOGGLE_ANALYTICS', |
| * Lifecycle Event | ||
| */ | ||
| componentWillMount() { | ||
| const title = 'Ghostery Hub - Home'; |
| class TutorialView extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
| this.props.history.push('/tutorial/1'); |
|
|
||
| export function setTutorialNavigation(data) { | ||
| return { | ||
| type: 'SET_TUTORIAL_NAVIGATION', |
| // }; | ||
| // return <SteppedNavigation {...navigationProps} />; | ||
| // } | ||
| // } |
| textPrev: t('hub_setup_nav_previous'), | ||
| textNext: t('hub_setup_nav_next'), | ||
| textDone: t('hub_setup_exit_flow'), | ||
| }); |
| constructor(props) { | ||
| super(props); | ||
|
|
||
| this.state = { | ||
| title: '' | ||
| title: 'Ghostery Hub - Tutorial Trust' |
| textPrev: t('hub_setup_nav_previous'), | ||
| textNext: t('hub_setup_nav_next'), | ||
| textDone: t('hub_setup_exit_flow'), | ||
| }); |
| textPrev: false, | ||
| textNext: t('hub_setup_nav_next'), | ||
| textDone: t('hub_setup_exit_flow'), | ||
| }); |
|
|
|
This was integrated into the |
|
^^^ Pull Request #179 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.