Feature/apres 8.2.4 bugs. Fixes for bugs found after 8.2.4 was about to be released. #168
Conversation
Contributor
zarembsky
commented
Aug 22, 2018
|
zarembsky
requested review from
IAmThePan,
jsignanini,
trickpattyFH20 and
ghostery/ghostery
as
code owners
|
Two bugs:
|
| @@ -39,6 +39,7 @@ export function log(...args) { | |||
|
|
|||
| if (hasErrors) { | |||
| console.error(...args); | |||
| console.trace(); | |||
zarembsky
Aug 22, 2018
Author
Contributor
It helps to identify where the error came from. Otherwise all you get is log message in red. Note that it is debug only.
It helps to identify where the error came from. Otherwise all you get is log message in red. Note that it is debug only.
| if (tab_url) { | ||
| this._updateUrl(tab_id, tab_url); | ||
| } | ||
| this._updateUrl(tab_id, tab_url); |
zarembsky
Aug 22, 2018
Author
Contributor
Because we don.t want to check in all places that, say, tab.path !== undefined
Because we don.t want to check in all places that, say, tab.path !== undefined
| path: '', | ||
| host_with_path: '', | ||
| anchor: '', | ||
| }; |
zarembsky
Aug 22, 2018
Author
Contributor
So that processUrl never returns empty object.
So that processUrl never returns empty object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.