Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring timeline of loading to avoid hangs. #170

Closed
wants to merge 13 commits into from

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Aug 22, 2018

  • [ x] Have you followed the guidelines in CONTRIBUTING.md?
  • [ x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Have you added an explanation of what your changes do?
  • [ x] Does your submission pass tests?
  • Did you lint your code prior to submission?
@zarembsky zarembsky requested a review from ghostery/ghostery as a code owner Aug 22, 2018
@zarembsky zarembsky requested a review from jsignanini Aug 22, 2018
@zarembsky
Copy link
Contributor Author

@zarembsky zarembsky commented Aug 22, 2018

We call account-related methods after all cliqz modules scheduled to be enabled are fully enabled, meaning that their respective on("enabled"...) handlers were called. setPrefs call is moved to the very end, so that we call expensive storage operation just once on startup.
We keep console.log expressions to show the esequence of startup events.

zarembsky added 7 commits Aug 22, 2018
@zarembsky
Copy link
Contributor Author

@zarembsky zarembsky commented Oct 30, 2018

There are two cases when it may hang. The prerequisites are same for both: any one of the following modules - offers, humanweb, antitracking or adblocking is disabled in settings of a user account.
Case 1. User is logged in and installing Ghostery.
Case 2. User disables one of cliqz modules on one device; on another device the user is logged in but has not yet open a panel. At this point an update happens.

@zarembsky zarembsky closed this Sep 14, 2019
@zarembsky zarembsky deleted the feature/hanging branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant