Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1012 fixes #174

Merged
merged 2 commits into from Aug 27, 2018
Merged

GH-1012 fixes #174

merged 2 commits into from Aug 27, 2018

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Aug 24, 2018

GH-1012 fixes:

  • remove justInstalled query param,
  • fix header newline,
  • fix font-family,
  • fix boldness
@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner Aug 24, 2018
@IAmThePan IAmThePan force-pushed the feature/hub-setup-update branch from c759d43 to 5c7ad70 Aug 24, 2018
@IAmThePan
GH-1012 fixes: setup header, feature boldness, font-family, remove qu…
Loading status checks…
da53759 
…ery param
@IAmThePan IAmThePan force-pushed the feature/hub-setup-update branch from 5c7ad70 to da53759 Aug 27, 2018
@IAmThePan
GH-1350 re-order blocking policies in setup flow
Loading status checks…
64e6143
@IAmThePan IAmThePan force-pushed the feature/hub-setup-update branch from 2175802 to 64e6143 Aug 27, 2018
@IAmThePan
Copy link
Contributor Author

@IAmThePan IAmThePan commented Aug 27, 2018

This PR also fixes the new updates to the Blocking step outlined in GH-1350
@jsignanini
jsignanini approved these changes Aug 27, 2018
View changes
@jsignanini jsignanini merged commit 0164f09 into develop Aug 27, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/hub-setup-update branch Aug 27, 2018
jsignanini added a commit that referenced this pull request Nov 20, 2018
@IAmThePan @jsignanini
GH-1012 fixes (#174)
bc4ebdd 
* GH-1012 fixes: setup header, feature boldness, font-family, remove query param

* GH-1350 re-order blocking policies in setup flow
jsignanini added a commit that referenced this pull request Nov 20, 2018
@IAmThePan @jsignanini
GH-1012 fixes (#174)
13ccd55 
* GH-1012 fixes: setup header, feature boldness, font-family, remove query param

* GH-1350 re-order blocking policies in setup flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@IAmThePan @jsignanini