Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ghostery pause and whitelisted sites to content scripts. #175

Merged
merged 2 commits into from Sep 4, 2018

Conversation

@sammacbeth
Copy link
Contributor

@sammacbeth sammacbeth commented Aug 28, 2018

Allows content scripts to stop processing when the user pauses ghostery.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@sammacbeth sammacbeth requested review from zarembsky and ghostery/ghostery as code owners Aug 28, 2018
Copy link
Member

@christophertino christophertino left a comment

@sammacbeth We should be able to handle the paused state change with a dispatcher event. In PanelData here and here we can add dispatcher.trigger('globals.save.paused_blocking').

In background.js under initializeDispatcher() add a listener for globals.save.paused_blocking and use that to call refreshAppState

sammacbeth added 2 commits Aug 16, 2018
Allows content scripts to stop processing when the user pauses ghostery
@sammacbeth sammacbeth force-pushed the sammacbeth:pause-content-scripts branch from 00b7589 to d56feef Sep 3, 2018
@sammacbeth
Copy link
Contributor Author

@sammacbeth sammacbeth commented Sep 3, 2018

@christophertino Thanks, was wondering if there was a nicer way to see when the extension is paused. Updated the PR with your suggestions.

@jsignanini jsignanini merged commit 5320435 into ghostery:develop Sep 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jsignanini added a commit that referenced this pull request Nov 19, 2018
* Pass ghostery pause and whitelisted sites to content scripts.

Allows content scripts to stop processing when the user pauses ghostery

* Use dispatcher to listen to paused status.
jsignanini added a commit that referenced this pull request Nov 20, 2018
* Pass ghostery pause and whitelisted sites to content scripts.

Allows content scripts to stop processing when the user pauses ghostery

* Use dispatcher to listen to paused status.
jsignanini added a commit that referenced this pull request Nov 20, 2018
* Pass ghostery pause and whitelisted sites to content scripts.

Allows content scripts to stop processing when the user pauses ghostery

* Use dispatcher to listen to paused status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants