Initial commit - rewards view #176
Closed
Conversation
Contributor
felixschmetz
commented
Aug 29, 2018
|
_locales/en/messages.json
Outdated
| "hub_rewards_header_learn_more": { | ||
| "message": "Learn More" | ||
| }, | ||
| "hub_rewards_first_icon_title": { |
IAmThePan
Aug 29, 2018
Contributor
change first_icon and similar to use more specific names: experience, privacy, relevant
change first_icon and similar to use more specific names: experience, privacy, relevant
app/images/hub/rewards/group-10.svg
Outdated
| @@ -0,0 +1,6 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="308" height="163" viewBox="0 0 308 163"> | |||
IAmThePan
Aug 29, 2018
Contributor
Please rename the image files to include a description of what the image is.
for example icon-star, icon-eye, etc.
Please rename the image files to include a description of what the image is.
for example icon-star, icon-eye, etc.
| <div className="second-icon columns"> | ||
|
|
||
| <div className="row align-center"> | ||
| <img src="/app/images/hub/rewards/group-6.svg" alt="smart"/> |
IAmThePan
Aug 29, 2018
Contributor
add the images using background-image and inline svgs in the css. you can look at app/scss/partials/_hub_svgs.scss, and app/hub/Views/SetupViews/SetupAntiSuite.scss for an example.
add the images using background-image and inline svgs in the css. you can look at app/scss/partials/_hub_svgs.scss, and app/hub/Views/SetupViews/SetupAntiSuite.scss for an example.
felixschmetz
force-pushed the
felixschmetz:feature/hub-rewards
branch
from
a8f790d
to
0950654
felixschmetz
force-pushed the
felixschmetz:feature/hub-rewards
branch
from
0950654
to
30e3082
|
We will reopen the same feature on a different branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.