Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-339 HomeView and SideNavigation for Ghostery Hub #179

Merged
merged 8 commits into from Aug 31, 2018
Merged

GH-339 HomeView and SideNavigation for Ghostery Hub #179

merged 8 commits into from Aug 31, 2018

Conversation

@felixschmetz
Copy link
Contributor

@felixschmetz felixschmetz commented Aug 31, 2018

Fix for rewards panel GH-1325
@felixschmetz felixschmetz requested review from IAmThePan, jsignanini, trickpattyFH20, zarembsky and ghostery/ghostery as code owners Aug 31, 2018
@IAmThePan IAmThePan changed the base branch from master to develop Aug 31, 2018
trickpattyFH20 and others added 3 commits Aug 15, 2018
@trickpattyFH20 @IAmThePan
GH-339 Ghostery hub navigation stub
e34fd22
@IAmThePan
GH-339 Ghostery Hub Home View
7252831 
Minor fixes
Felix Schmetz @IAmThePan
Finalize SideNavigation, tests for HomeView
Loading status checks…
ca19d8f
@IAmThePan IAmThePan force-pushed the feature/side-navigation branch from b290609 to ca19d8f Aug 31, 2018
IAmThePan added 2 commits Aug 31, 2018
@IAmThePan
Fix tests and linting errors.
Loading status checks…
76cc962
@IAmThePan
Fix more tests
Loading status checks…
f1cd275
@IAmThePan IAmThePan mentioned this pull request Aug 31, 2018
Closed
@IAmThePan
Merge branch 'develop' into feature/side-navigation
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
a03c5d1
@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Aug 31, 2018

This pull request addresses:
GH-339: The Ghostery Hub home view and the side navigation
GH-1358: Updates to the Rewards view
@jsignanini
Copy link
Member

@jsignanini jsignanini commented Aug 31, 2018

@IAmThePan 2 issues I can see right away:

  1. On fresh install, the hub page opens, with "Home" tab selected, but "Customize Settings" is in blue.
  2. On small screens, selecting different tabs changes the tab title to 2 or more lines even if they originally were 1 or 2 lines.
IAmThePan added 2 commits Aug 31, 2018
@IAmThePan
Fix link color and navigation two line error
5105e48
@IAmThePan
Merge remote-tracking branch 'upstream/feature/side-navigation' into …
Loading status checks…
58938a4 
…feature/side-navigation
@jsignanini
jsignanini approved these changes Aug 31, 2018
View changes
@jsignanini jsignanini merged commit 3616ae4 into develop Aug 31, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jsignanini jsignanini deleted the feature/side-navigation branch Aug 31, 2018
jsignanini added a commit that referenced this pull request Nov 20, 2018
@felixschmetz @jsignanini
GH-339 HomeView and SideNavigation for Ghostery Hub (#179)
f2c208c 
* GH-339 Ghostery hub navigation stub

* GH-339 Ghostery Hub Home View

Minor fixes

* Finalize SideNavigation, tests for HomeView

* Fix tests and linting errors.

* Fix more tests

* Fix link color and navigation two line error
jsignanini added a commit that referenced this pull request Nov 20, 2018
@felixschmetz @jsignanini
GH-339 HomeView and SideNavigation for Ghostery Hub (#179)
04650e3 
* GH-339 Ghostery hub navigation stub

* GH-339 Ghostery Hub Home View

Minor fixes

* Finalize SideNavigation, tests for HomeView

* Fix tests and linting errors.

* Fix more tests

* Fix link color and navigation two line error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

@IAmThePan IAmThePan

@trickpattyFH20 trickpattyFH20

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@felixschmetz @IAmThePan @jsignanini @trickpattyFH20