Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghostery Hub - Tutorial Flow #187

Merged
merged 9 commits into from Sep 11, 2018
Merged

Ghostery Hub - Tutorial Flow #187

merged 9 commits into from Sep 11, 2018

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Sep 11, 2018

Implement the Ghostery Hub Tutorial Flow.
Other features

  • Update Side Navigation to only gray out menu items for the Customize Setup and Tutorial flows.
  • Remove Exit Buttons for Create Account and Log In views
  • General formatting changes
IAmThePan added 7 commits Sep 4, 2018
@IAmThePan
First pass at tutorial. Need to add images
1ace8b3
@IAmThePan
Small changes: comments and scrolling sass fixes
1c2aabd
@IAmThePan
update images in tutorial flow
e3812de
@IAmThePan
Add video tag to tutorial
fde2bc5
@IAmThePan
Add some tests, bring image into extension
abef930
@IAmThePan
Merge with develop
875563f
@IAmThePan
Updates for style, linting and unit tests
Loading status checks…
50cf9db
@IAmThePan IAmThePan requested a review from ghostery/ghostery as a code owner Sep 11, 2018
@IAmThePan IAmThePan changed the title GH-1011 Ghostery Hub - Tutorial Flow Sep 11, 2018
@IAmThePan
Copy link
Contributor Author

@IAmThePan IAmThePan commented Sep 11, 2018 •
edited

57 Files Changed:

  • 10 are images
  • 18 are small changes to comments in files or slightly rearranging component index files,
  • 3 are new or updated test files
  • 3 are using or removing shared components from files.

@jsignanini Please approve.
IAmThePan added 2 commits Sep 11, 2018
@IAmThePan
Decrease padding and center content for tutorial views
Loading status checks…
b3b4116
@IAmThePan
update unit test errors
Loading status checks…
cb665dc
@jsignanini
jsignanini approved these changes Sep 11, 2018
View changes
@jsignanini jsignanini merged commit 48456ef into develop Sep 11, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@jsignanini jsignanini deleted the feature/tutorial branch Sep 11, 2018
jsignanini added a commit that referenced this pull request Nov 20, 2018
@IAmThePan @jsignanini
Ghostery Hub - Tutorial Flow (#187)
04576a6
jsignanini added a commit that referenced this pull request Nov 20, 2018
@IAmThePan @jsignanini
Ghostery Hub - Tutorial Flow (#187)
e12dc94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@IAmThePan @jsignanini