Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old Ghsotery Setup page and all its related code #189

Merged
merged 2 commits into from Sep 13, 2018

Conversation

@IAmThePan
Copy link
Contributor

@IAmThePan IAmThePan commented Sep 12, 2018

I removed all the code that was part of the old Setup workflow.

  • everything in app/setup
  • the setup template file: app/templates/setup.html
  • the setup scss file: app/scss/setup.scss
  • relevant message handlers in src/background
  • a ping in src/classes/Metrics
  • jsdoc.json
  • the relevant compile files in webpack.config.js
  • all the setup_... strings in _locales/en.
    • I had to rename one string that was used elsewhere. (setup_footer_license -> license_footer in app/licenses/Licenses.jsx)
    • I had to update a string to not use a deprecated string (setup_button_done -> hub_setup_nav_done in app/hub/Views/SetupViews/SetupBlockingDropdown/SetupBlockingDropdown.jsx)

@christophertino Please check if I need to remove any additional files.

@IAmThePan IAmThePan requested review from jsignanini, trickpattyFH20, zarembsky and ghostery/ghostery as code owners Sep 12, 2018
@christophertino christophertino merged commit 1b2486f into develop Sep 13, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the feature/remove-old-setup branch Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants