Refactor integration ghostery whitelisting with Cliqz modules #23
Conversation
|
@sammacbeth looks like some check failed, could you please take a look? Maybe some unit test needs updating. |
a8ae3dc
to
61de9e2
|
Looks OK, though with this change Ghostery code is getting tied more closely to Cliqz code. A change in pipeline steps in Cliqz side might require changes on Ghostery side. |
|
@zarembsky Pipeline steps should not change often on the cliqz side. Also, in comparison to the previous method, this one will fail with an error if an incompatible change occurs. |
…locker from Ghostery side
61de9e2
to
05ceff9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR implements whitelisting of urls in the anti-tracking and adblocker pipelines based on the
ghosteryWhitelistedsignal. I've also refactored the registration of this whitelisting function to use actions, which will be more robust to changes in thebrowser-corepackage.This required some further changes on the
browser-coreside, so I have updated the dependency to a build based off 1.26.1.